[Owncloud] Review Request 102492: Fix bug: filenames in filelisting are not shown for files without extension
Albert Astals Cid
aacid at kde.org
Thu Feb 7 21:20:24 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102492/#review26888
-----------------------------------------------------------
I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?
- Albert Astals Cid
On Aug. 30, 2011, 6:20 p.m., Elias Probst wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102492/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2011, 6:20 p.m.)
>
>
> Review request for ownCloud.
>
>
> Description
> -------
>
> There is a bug in the filelisting (files/index.php) which causes troubles when listing files which don't have an extension, e.g.
> Test123 vs. Test123.txt
>
> The filenames of such files were only shown when hovering them.
> The reason for this behaviour was the hackish approach on splitting the filename by using substr() and strrpos().
>
> The bugfix uses now PHP's builtin pathinfo() to do this job.
>
>
> Diffs
> -----
>
> files/index.php 0595463
>
> Diff: http://git.reviewboard.kde.org/r/102492/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Filename for files without extension is only shown on hover
> http://git.reviewboard.kde.org/r/102492/s/244/
>
>
> Thanks,
>
> Elias Probst
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/owncloud/attachments/20130207/4892c828/attachment.html>
More information about the Owncloud
mailing list