[Owncloud] [QA-Announcement] Code Reviews to increase quality

Sam Tuke samtuke at owncloud.com
Mon Oct 29 23:59:21 UTC 2012

On 10/29/2012 11:43 PM, Jan-Christoph Borchardt wrote:
> TL;DR: Do not directly push to core master, and instead use pull
> requests.

How much of the procedure is enforced, and how much relies upon convention?
Who counts as a "reviewer" - should only certain people fulfil this role
(are there specific reviewers for specific files / apps)?
Can people who aren't members of ownCloud on GitHub also act as reviewers?
Do +1s have to take a specific form, or are comments like "looks good"
Is it now literally not possible to commit directly to core master?

Great progress guys, awesome work!


More information about the Owncloud mailing list