[Owncloud] [urgent] need help to fix an javascript bug in the sharing app

[Victor Dubiniuk]

Hi Bjoern,

It's probably cache-related. Can you please add to your config.php this line

define('DEBUG', true);

and retest?

In the context of
https://github.com/owncloud/core/blob/master/core/js/share.js#L372

'this' means the whole document. So there are two solutions at that point:
filter undesired elements or use

$('#content').click(function(event) {

instead of

$(this).click(function(event) {


As long as datepicker is a sibling of div#content the latter won't catch
the bubbling click event in this case.

---
Victor

On Mon, Oct 8, 2012 at 11:22 PM, Bjoern Schiessle <schiessle at owncloud.com>wrote:

> Hi Victor,
>
> On Mon, 8 Oct 2012 22:06:35 +0300 Victor Dubiniuk wrote:
> > Can you check if this commit solves this issue completely?
> >
> https://github.com/owncloud/core/commit/06d00af9f89d9c858b6f7a3fb11de85d4da8d6fc
>
> I tried it, but for me the share dialogue still gets closed if I try to
> switch to a different month.
>
> Earlier this day I also looked at OC.Share.hideDropDown() and
> thought that this is the function responsible to close the share
> dialogue. But even if I remove all OC.Share.hideDropDown() calls, the
> dialogue still gets closed both in wanted and unwanted (navigating in
> the date picker) situations.
>
> cheers,
> Björn
>
>
> --
> Björn Schießle <schiessle at owncloud.com>
> Software Developer
> ownCloud GmbH
>
> Your Data, Your Cloud, Your Way!
>
> ownCloud GmbH, GF: Markus Rex, Holger Dyroff
> Schloßäckerstrasse 26a, 90443 Nürnberg, HRB 28050 (AG Nürnberg)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/owncloud/attachments/20121008/a4e4b1f4/attachment.html>