[Owncloud] Commiting Oracle support tomorrow, beware of SQL without escaped identifiers

[Sebastian Kügler]

On Friday, August 24, 2012 19:31:42 Jörn Friedrich Dreyer wrote:
> I am currently merging master into my personal stable4-oracle branch and
> will commit oracle support tomorrow. This will allow us to give the
> implementation a lot of testing before owncloud customers will be using
> it in production.

Strikes me, and the amount of breakage and subsequent comments seems to 
support this feeling, that the branch should be well tested *before* being 
merged into master, not merging into master as trigger for people to actually 
test it and then hope that bugs are actually being fixed. Motivation for 
fixing bugs is usually much higher pre-merge than post-merge.

(And I don't mean "test Oracle support", much more "test for regressions to 
the current feature set" -- and fix them.)

>From my experience, maintaining support for multiple databases (and their 
creative variants of SQL) is pure madness without a layer that takes care of 
these differences. Even then, it's not a walk in the park. Of course, it can 
be gotten right, but only with a very strict testing mentality. "Merge, and 
see if it breaks" is not that mentality.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9