[Owncloud] patch about music collection.

[Robin Appelman]

On Wednesday 24 August 2011 23:26:54 Côme BERNIGAUD wrote:
> Hello, the display of songs in the media apps seemed wrong so I worked
> on collection.js a little.
As I said on irc, the thing that looked "wrong" is a design choice (maybe a 
bad one, that's open for discussion)

> It's far from perfect but at least it does the job. (I don't think we
> should add/remove table rows in javascript, I would prefer hiding rows
> with CSS and then showing them thanks to CSS3)
I originally did the show/hidding with css but that caused a big problem with 
large collections, processing the collection and building the entire table 
took about 10 secconds and basically froze the browser for that durration.

> 
> So now artists can be hide/shown and albums as well.
> 
> I also fixed a typo (collection instead of Collection was causing an
> error in the javascript console)
That "collection" refered an old local variable instead of the global object, 
thanks for finding this one, I replaced it with the correct variable.

> 
> You can download the patch here :
> http://mcmic.haxx.es/owncloud/collection.patch
> (I just did "git diff collection.js > collection.patch", if you need
> other informations, just ask)
> And the whole file here :
> http://mcmic.haxx.es/owncloud/apps/media/js/collection.js
> 
> Any remarks?
> If not could someone commit this to the git?

Don't let this stop you from doing further work on the media player :)

 - Robin Appelman