D21630: Change Browse icon back to the hand shape
Albert Astals Cid
noreply at phabricator.kde.org
Thu Jun 6 22:59:41 BST 2019
aacid added a comment.
In D21630#475517 <https://phabricator.kde.org/D21630#475517>, @ndavis wrote:
> In D21630#475501 <https://phabricator.kde.org/D21630#475501>, @aacid wrote:
>
> > **wow** Not even one minute to review things
> >
> > I don't particularly like this, input-mouse is an icon that exists in most icon themes
> > extra/adwaita-icon-theme
> > extra/breeze-icons
> > extra/efl
> > extra/gnome-icon-theme
> > extra/gnome-icon-theme-symbolic
> > extra/gnome-themes-extra
> > extra/oxygen-icons
> > extra/oxygen-icons-svg
> > extra/qt5-doc
> > extra/xf86-input-mouse
> > extra/xfce4-power-manager
> > community/arc-icon-theme
> > community/elementary-icon-theme
> > community/faba-icon-theme
> > community/faenza-icon-theme
> > community/lxinput
> > community/lxinput-gtk3
> > community/mate-icon-theme
> > community/mate-icon-theme-faenza
> > community/mate-themes
> > community/moka-icon-theme
> > community/papirus-icon-theme
> >
> > transform-browse exists only in breeze-icons
> >
> > but 🤷♂️ i guess
>
>
> Sorry, I'll wait longer in the future, but input-mouse is still wrong. This simply doesn't mean the same thing as "grabber" or "browse": https://raw.githubusercontent.com/GNOME/adwaita-icon-theme/master/Adwaita/22x22/legacy/input-mouse.png
I know, but at least is an icon that exists.
On the other hand thanks to my fixes to kicontheme >= 5.50 and Qt >= 5.12 if the icon doesn't exist in the user icon theme it'll try to fallback to breeze, will look ultra weird but at least won't be a button without text nor icon
i guess it can stay
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21630
To: ndavis, #okular, #vdg, ngraham
Cc: aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190606/fb384989/attachment-0001.html>
More information about the Okular-devel
mailing list