<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21630">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D21630#475517" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D21630#475517</a>, <a href="https://phabricator.kde.org/p/ndavis/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ndavis</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D21630#475501" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D21630#475501</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p><strong>wow</strong> Not even one minute to review things</p>

<p>I don't particularly like this, input-mouse is an icon that exists in most icon themes<br />
 extra/adwaita-icon-theme<br />
 extra/breeze-icons<br />
 extra/efl<br />
 extra/gnome-icon-theme<br />
 extra/gnome-icon-theme-symbolic<br />
 extra/gnome-themes-extra<br />
 extra/oxygen-icons<br />
 extra/oxygen-icons-svg<br />
 extra/qt5-doc<br />
 extra/xf86-input-mouse<br />
 extra/xfce4-power-manager<br />
 community/arc-icon-theme<br />
 community/elementary-icon-theme<br />
 community/faba-icon-theme<br />
 community/faenza-icon-theme<br />
 community/lxinput<br />
 community/lxinput-gtk3<br />
 community/mate-icon-theme<br />
 community/mate-icon-theme-faenza<br />
 community/mate-themes<br />
 community/moka-icon-theme<br />
 community/papirus-icon-theme</p>

<p>transform-browse exists only in breeze-icons</p>

<p>but 🤷‍♂️ i guess</p></div>
</blockquote>

<p>Sorry, I'll wait longer in the future, but input-mouse is still wrong. This simply doesn't mean the same thing as "grabber" or "browse": <a href="https://raw.githubusercontent.com/GNOME/adwaita-icon-theme/master/Adwaita/22x22/legacy/input-mouse.png" class="remarkup-link" target="_blank" rel="noreferrer">https://raw.githubusercontent.com/GNOME/adwaita-icon-theme/master/Adwaita/22x22/legacy/input-mouse.png</a></p></div>
</blockquote>

<p>I know,  but at least is an icon that exists.</p>

<p>On the other hand thanks to my fixes to kicontheme >= 5.50 and Qt >= 5.12 if the icon doesn't exist in the user icon theme it'll try to fallback to breeze, will look ultra weird but at least won't be a button without text nor icon</p>

<p>i guess it can stay</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21630">https://phabricator.kde.org/D21630</a></div></div><br /><div><strong>To: </strong>ndavis, Okular, VDG, ngraham<br /><strong>Cc: </strong>aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen<br /></div>