D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn marked an inline comment as done.
michaelweghorn added inline comments.

INLINE COMMENTS

> aacid wrote in document.h:728
> this is binary incompatible :/
> 
> We could just let it be a QWidget but document it has to be a PrintOptionsWidge subclass, and then on the user do a dynamic_cast and complain if it is not a PrintOptionsWidget, but maybe we can just say meh and break the BC.

I have changed the return type to a QWidget* again, but only for the Document class itself, not in the other places. As far as I understand, this place here is the only one relevant for the ABI. Is this correct?

Currently, there is no complaint if a plain QWidget* is returned, it's just handled as it used to be then. Should I change that (e.g. emit a 'qWarning()')?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190115/dfca9e1d/attachment-0001.html>