D10974: Add option to ignore print margins for non-PDF generators

Michael Weghorn noreply at phabricator.kde.org
Tue Jan 15 10:36:53 GMT 2019


michaelweghorn updated this revision to Diff 49510.
michaelweghorn edited the summary of this revision.
michaelweghorn added a comment.


  Adapt according to Albert's feedback:
  
  - undo ABI breakage by changing back signature of 'Document::printConfigurationWidget()' to  what it is like without this change, and use a 'dynamic_cast' in 'Part::slotPrint'.
  - drop 'virtual' for 'PDFOptionsPage::ignorePrintMargins()'

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10974?vs=49223&id=49510

BRANCH
  michaelweghorn/WAITING_FOR_REVIEW_D10974_add_scaling_options_for_other_generators

REVISION DETAIL
  https://phabricator.kde.org/D10974

AFFECTED FILES
  CMakeLists.txt
  core/document.cpp
  core/document.h
  core/fileprinter.cpp
  core/printoptionswidget.cpp
  core/printoptionswidget.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  interfaces/printinterface.h
  part.cpp

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190115/815ab31d/attachment.html>


More information about the Okular-devel mailing list