D18144: Implemented find function from console

Yuri Chornoivan noreply at phabricator.kde.org
Thu Jan 10 06:43:03 GMT 2019


yurchor added inline comments.

INLINE COMMENTS

> shellutils.cpp:85
>  {
> -    return QStringLiteral("%1:%2:%3:%4:%5:%6").arg(startInPresentation).arg(showPrintDialog).arg(showPrintDialogAndExit).arg(unique).arg(noRaise).arg(page);
> +    return QStringLiteral("%1:%2:%3:%4:%5:%6:%7").arg(startInPresentation).arg(showPrintDialog).arg(showPrintDialogAndExit).arg(unique).arg(noRaise).arg(page).arg(find);
>  }

Can this be written as

  return QStringLiteral("%1:%2:%3:%4:%5:%6:%7").arg(startInPresentation, showPrintDialog, showPrintDialogAndExit, unique, noRaise, page, find);

?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18144

To: joaonetto
Cc: yurchor, okular-devel, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190110/8967f029/attachment-0001.html>


More information about the Okular-devel mailing list