D18144: Implemented find function from console

Joao Oliveira noreply at phabricator.kde.org
Thu Jan 10 00:05:00 GMT 2019


joaonetto added inline comments.

INLINE COMMENTS

> part.cpp:1724
>      }
>  
> +    if( url.hasQuery() ){

Is this some bad practices? I'm sending as ID for search 1, since it's the first search, fromStart is set as false, since the document could be in another page. Change viewport is set as 1, since it has to change.

Everything else I set default values, one problem is that I can't continue the search, I just find the first ocurrence.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18144

To: joaonetto
Cc: okular-devel, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190110/db54735e/attachment.html>


More information about the Okular-devel mailing list