D15205: Support setting font color for typewriter annotation

[Tobias Deiminger]

tobiasdeiminger added inline comments.

INLINE COMMENTS

> editannottooldialog.cpp:275
>          engineElement.setAttribute( QStringLiteral("type"), QStringLiteral("PickPoint") );
> -        engineElement.setAttribute( QStringLiteral("color"), QStringLiteral("#000000") );
> +        engineElement.setAttribute( QStringLiteral("color"), fontColor );
>          engineElement.setAttribute( QStringLiteral("block"), QStringLiteral("true") );

engine [color] seems to be too ambiguous to store font color in it. Consider near future, when we want to implement font color support for inline notes. Then we have two different colors for one annotation, namely "background color" and "text color". One general color attribute (engine [color] / annotation [color] ) is not sufficient there. I think it's better to introduce a new annotation [textColor] attribute now.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15205

To: tobiasdeiminger
Cc: sander, okular-devel, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180927/0e260a16/attachment.html>