<table><tr><td style="">tobiasdeiminger added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15205">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15205#inline-85373">View Inline</a><span style="color: #4b4d51; font-weight: bold;">editannottooldialog.cpp:275</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">engineElement</span><span class="p">.</span><span class="n">setAttribute</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"type"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"PickPoint"</span><span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">engineElement</span><span class="p">.</span><span class="n">setAttribute</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"color"</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"#000000"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">engineElement</span><span class="p">.</span><span class="n">setAttribute</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"color"</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">fontColor</span></span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">engineElement</span><span class="p">.</span><span class="n">setAttribute</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"block"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"true"</span><span class="p">)</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">engine [color] seems to be too ambiguous to store font color in it. Consider near future, when we want to implement font color support for inline notes. Then we have two different colors for one annotation, namely "background color" and "text color". One general color attribute (engine [color] / annotation [color] ) is not sufficient there. I think it's better to introduce a new annotation [textColor] attribute now.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15205">https://phabricator.kde.org/D15205</a></div></div><br /><div><strong>To: </strong>tobiasdeiminger<br /><strong>Cc: </strong>sander, okular-devel, ngraham, aacid<br /></div>