D15279: Store all annotation color attributes as ARGB string

[Tobias Deiminger]

tobiasdeiminger added a comment.


  In D15279#320991 <https://phabricator.kde.org/D15279#320991>, @sander wrote:
  
  > I cannot reproduce Part 1 of your test plan.  When I delete my `okularpartrc` and start Okular (with the patch), then the freshly created `okularpartrc` file
  
  
  When is your new okularpartrc created exactly? Afaikt, it should not be created right on startup, but only when you modify some tool in the config dialog.
  
  > contains all colors as RGB, not ARGB.
  
  Strange, for me it works. New okularpartrc looks like this
  
    AnnotationTools=<tool id="1" type="note-linked"><engine hoverIcon="tool-note" color="#ffff00" type="PickPoint"><annotation icon="Note" color="#ffffff00" type="Text"/></engine><shortcut>1</shortcut></tool> [...]
  
  Are you sure you looked at <annotation color="...">, and not at <engine color="...">? The first one is what matters.
  
  > This doesn't seem to have any negative consequences, however.
  
  Existing annotations don't consider alpha channel, so you don't notice it for now. But it would have negative consequence for typewriter.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15279

To: tobiasdeiminger
Cc: sander, okular-devel, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180905/37632ffd/attachment.html>