D16364: Resolve symlinks before saving so we don't "break" them

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks for the patch! However this does not actually work for me. See the following video (taken with the patch applied): F6342100: doesn't work.webm <https://phabricator.kde.org/F6342100>
  
  I think `realSaveUrl.toLocalFile()` needs to be `saveUrl.toLocalFile()`. Then it works.

INLINE COMMENTS

> part.cpp:2540
> +    // Figure out the real save url, for symlinks we don't want to copy over the symlink but over the target file
> +    const QUrl realSaveUrl = saveUrl.isLocalFile() ? QUrl::fromLocalFile( QFileInfo( realSaveUrl.toLocalFile() ).canonicalFilePath() )
> +                                                   : saveUrl;

Shouldn't `realSaveUrl.toLocalFile()` be `saveUrl.toLocalFile()`?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16364

To: aacid, ngraham
Cc: ngraham, okular-devel, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20181021/7063cbfa/attachment.html>