<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16364">View Revision</a></tr></table><br /><div><div><p>Thanks for the patch! However this does not actually work for me. See the following video (taken with the patch applied): <a href="https://phabricator.kde.org/F6342100" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6342100: doesn't work.webm</a></p>

<p>I think <tt style="background: #ebebeb; font-size: 13px;">realSaveUrl.toLocalFile()</tt> needs to be <tt style="background: #ebebeb; font-size: 13px;">saveUrl.toLocalFile()</tt>. Then it works.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16364#inline-89085">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.cpp:2540</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// Figure out the real save url, for symlinks we don't want to copy over the symlink but over the target file</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span class="n">realSaveUrl</span> <span style="color: #aa2211">=</span> <span class="n">saveUrl</span><span class="p">.</span><span class="n">isLocalFile</span><span class="p">()</span> <span style="color: #aa2211">?</span> <span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromLocalFile</span><span class="p">(</span> <span class="n">QFileInfo</span><span class="p">(</span> <span class="n">realSaveUrl</span><span class="p">.</span><span class="n">toLocalFile</span><span class="p">()</span> <span class="p">).</span><span class="n">canonicalFilePath</span><span class="p">()</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                   <span style="color: #aa2211">:</span> <span class="n">saveUrl</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Shouldn't <tt style="background: #ebebeb; font-size: 13px;">realSaveUrl.toLocalFile()</tt> be <tt style="background: #ebebeb; font-size: 13px;">saveUrl.toLocalFile()</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16364">https://phabricator.kde.org/D16364</a></div></div><br /><div><strong>To: </strong>aacid, ngraham<br /><strong>Cc: </strong>ngraham, okular-devel, aacid<br /></div>