D17054: Retina Support for MacOS

[René J.V. Bertin]

rjvbb added a comment.


  This change does more than just enabling hidpi support in the plist.
  
  > Given you've been doing the same patch for multipple apps now, any chance this can be generated using an ECM macro, pernhaps populated from the app's desktop file or appstream data?
  
  Generating the correct XML from that data is maybe a bit of a tall order for cmake's language?
  
  As to the hidpi support: why is it necessary to set that in the plist in addition to what's done in the code? This seems like something that should be fixed in Qt's cmake modules or even in cmake itself (wherever the default Info.plist model comes from).
  
  FWIW, `LSMultipleInstancesProhibited` should of course not be set by default (should it for Okular which seems to launch in multiple instances on Linux?)
  
  Lastly: please add `kde-mac` to the subscriber list for Mac-related reviews.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17054

To: darcyshen, #okular
Cc: rjvbb, broulik, ltoscano, okular-devel, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20181121/a3349328/attachment-0001.html>