D13170: Add test for additional form actions

[Albert Astals Cid]

aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.


  QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant".
  
  In those cases you awnt to use the QTRY_ versions, i.e. QTRY_VERIFY2 instead of QVERIFY2
  
  Also you probably want QCOMPARE instead of QVERIFY if your QVERIFY has a == inside, because that way when it fails it already says the expected: actual: values without you having to construct the string (in this case we want QTRY_COMPARE to be able to remove the wait() calls).
  
  Hope i made sense :D

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13170

To: aheinecke, aacid
Cc: okular-devel, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180528/1597c208/attachment-0001.html>