D11723: Add FormFieldSignature to Okular namespace

Albert Astals Cid noreply at phabricator.kde.org
Wed May 23 22:54:49 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> signatureinfo.h:33
> +         */
> +        virtual int signatureStatus() const;
> +

int is bad, this, certificateStatus and hashAlgorithm need to be enums, what am i supposed to do with this returning 3? What does 3 mean?

> signatureinfo.h:58
> +         */
> +        virtual time_t signingTime() const;
> +

time_t is bad, we want QDateTime

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: ngraham, okular-devel, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180523/74aa641c/attachment-0001.html>


More information about the Okular-devel mailing list