D11074: Fix opening files via a file manager on Mac

Sergio Bragin noreply at phabricator.kde.org
Tue Mar 6 18:48:16 UTC 2018


sbragin added a comment.


  In D11074#220158 <https://phabricator.kde.org/D11074#220158>, @rjvbb wrote:
  
  > There is no specific reason to hide the QFileOpenEvent handling in a Mac-specific file and behind #ifdefs . I seem to recall that the same event mechanism was used on another, now defunct Qt platform. Other KDE applications (notably Kate) don't bother and just include the extra code unconditionally.
  
  
  Would not it end with having #ifdefs scattered all over the QApplication anyway? I guess the dependent patch would need some #ifdefs then.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11074

To: sbragin
Cc: ltoscano, rjvbb, #okular, michaelweghorn, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180306/da0ef279/attachment-0001.html>


More information about the Okular-devel mailing list