D13203: Add Typewriter annotation tool in Okular

[Oliver Sander]

sander added inline comments.

INLINE COMMENTS

> dileepsankhla wrote in annots.cpp:182
> 1. Do I need to do something like this in okular/generators/poppler/annots.cpp:
> 
> 
> 
>   #ifdef HAVE_POPPLER_0_67
>   
>   ppl_txtann->setTextColor( okl_txtann->textColor() );
>   
>   #endif //HAVE_POPPLER_0_67
> 
> 
> 
> 2. I didn't get what to do in generators/poppler/CMakeLists.txt. May you provide me an example?

1.) yes

2. You need to write a test that sets the HAVE_POPPLER_0_67 flag. Have a look at that CMakeLists.txt file.  It contains calls to check_cxx_source_compiles. Each call contains a small C++ program and a HAVE_POPPLER_*** flag. The build system tries to compile the program, and if that works, then the flag is set.  You need to write a new call that tests for your setTextColor method, and set the HAVE_POPPLER_0_67 flat.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13203

To: dileepsankhla, tobiasdeiminger
Cc: sander, ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180717/fc9b2dc0/attachment.html>