D9692: Improve message displayed when PDF wants to open in presentation mode

[Henrik Fehlauer]

rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.


  You should open a 48h bugfixing service ;)
  
  Example PDF (via https://tex.stackexchange.com/a/219791): F5623940: presentation_mode.pdf <https://phabricator.kde.org/F5623940>

INLINE COMMENTS

> part.cpp:1627
>          {
> -            const QString text = i18n( "The document requested to be launched in presentation mode.\n"
> -                                       "Do you want to allow it?" );
> +            const QString text = i18n( "This document wants to be shown in presentation mode. Enter presentation mode now?" );
>              const QString caption = i18n( "Presentation Mode" );

While testing, I thought "The last sentence should be on a new line", because a narrower dialog would be easier to read. And indeed, looking at the code there was a line break before. Please keep it.

> part.cpp:1630
> +            const KGuiItem yesItem = KGuiItem( i18n( "Enter" ), QStringLiteral("dialog-ok"), i18n( "Enter presentation mode" ) );
> +            const KGuiItem noItem = KGuiItem( i18n( "Stay" ), QStringLiteral("process-stop"), i18n( "Stay in normal mode" ) );
>              const int result = KMessageBox::questionYesNo( widget(), text, caption, yesItem, noItem );

Why not just Cancel? Seems more common to me.

Perhaps use `KStandardGuiItem::cancel()` and manually `setToolTip()`?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9692

To: ngraham, #okular, aacid, rkflx
Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180106/4cd5ad96/attachment-0001.html>