<table><tr><td style="">rkflx requested changes to this revision.<br />rkflx added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9692" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>You should open a 48h bugfixing service ;)</p>
<p>Example PDF (via <a href="https://tex.stackexchange.com/a/219791" class="remarkup-link" target="_blank" rel="noreferrer">https://tex.stackexchange.com/a/219791</a>): <a href="https://phabricator.kde.org/F5623940" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5623940: presentation_mode.pdf</a></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9692#inline-43928" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.cpp:1627</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">text</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"Th<span class="bright">e document requested to be launched in presentation mode.</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\n</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #766510">"Do you want to allow it?"</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">text</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"Th<span class="bright">is document wants to be shown in presentation mode. Enter presentation mode now?"</span></span><span class="bright"> </span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">caption</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"Presentation Mode"</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">While testing, I thought "The last sentence should be on a new line", because a narrower dialog would be easier to read. And indeed, looking at the code there was a line break before. Please keep it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9692#inline-43927" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.cpp:1630</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">const</span> <span class="n">KGuiItem</span> <span class="n">yesItem</span> <span style="color: #aa2211">=</span> <span class="n">KGuiItem</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"<span class="bright">Allow</span>"</span> <span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"dialog-ok"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"<span class="bright">Allow the</span> presentation mode"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">const</span> <span class="n">KGuiItem</span> <span class="n">noItem</span> <span style="color: #aa2211">=</span> <span class="n">KGuiItem</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"<span class="bright">Do Not Allow"</span></span><span class="bright"> </span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"process-stop"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Do not allow the presentation</span> mode"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">KGuiItem</span> <span class="n">yesItem</span> <span style="color: #aa2211">=</span> <span class="n">KGuiItem</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"<span class="bright">Enter</span>"</span> <span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"dialog-ok"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"<span class="bright">Enter</span> presentation mode"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">KGuiItem</span> <span class="n">noItem</span> <span style="color: #aa2211">=</span> <span class="n">KGuiItem</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"<span class="bright">Stay"</span></span><span class="bright"> </span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"process-stop"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Stay in normal</span> mode"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">result</span> <span style="color: #aa2211">=</span> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">questionYesNo</span><span class="p">(</span> <span class="n">widget</span><span class="p">(),</span> <span class="n">text</span><span class="p">,</span> <span class="n">caption</span><span class="p">,</span> <span class="n">yesItem</span><span class="p">,</span> <span class="n">noItem</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why not just <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Cancel</span></span></span>? Seems more common to me.</p>
<p style="padding: 0; margin: 8px;">Perhaps use <tt style="background: #ebebeb; font-size: 13px;">KStandardGuiItem::cancel()</tt> and manually <tt style="background: #ebebeb; font-size: 13px;">setToolTip()</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9692" rel="noreferrer">https://phabricator.kde.org/D9692</a></div></div><br /><div><strong>To: </strong>ngraham, Okular, aacid, rkflx<br /><strong>Cc: </strong>rkflx, michaelweghorn, gassaf, ngraham, aacid<br /></div>