D10455: Add RTL support for search, copy & paste in pdf

Albert Astals Cid noreply at phabricator.kde.org
Mon Feb 19 08:26:04 UTC 2018


aacid added a comment.


  In D10455#209288 <https://phabricator.kde.org/D10455#209288>, @fahadalsaidi wrote:
  
  > @aacid Thanks for the feedback.
  >
  > > And you have a memory leak in your function as reported by
  >
  > valgrind shows that the leak happen in:
  >
  >   makeWordFromCharacters(QList<TinyTextEntity*> const&, int, int) (textpage.cpp:1209)
  >
  >
  > which needs to be fix but not in this patch since it is irrelevant to it.
  
  
  No, the new code is causing that leak.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180219/d3286100/attachment.html>


More information about the Okular-devel mailing list