D10455: Add RTL support for search, copy & paste in pdf
Fahad Al-Saidi
noreply at phabricator.kde.org
Mon Feb 19 05:26:33 UTC 2018
fahadalsaidi added a comment.
@aacid Thanks for the feedback.
> I'm still unconvinced the text reversion is happening at the proper level.
I really a new to okular's code, so please guide me to the right direction.
> And you have a memory leak in your function as reported by
valgrind shows that the leak happen in:
makeWordFromCharacters(QList<TinyTextEntity*> const&, int, int) (textpage.cpp:1209)
which needs to be fix but not in this patch since it is irrelevant to it.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D10455
To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180219/4ee8b04f/attachment-0001.html>
More information about the Okular-devel
mailing list