D10797: Add asterisk when an annotation is associated to non-empty popup

[Simone Gaiarin]

simgunz added a comment.


  What is the best way to implement this? Given the call to i18n I guess I cannot just append a suffix to ret.
  Should I do for each annotation type something like:
  
    bool hasComment = !ann->contents().isEmpty();
    ret =  hasComment ? i18n( "Highlight with Comment" ) : i18n( "Highlight Note" );
  
  I guess I do not need to add "with Comment" to Pop-up note and Inline note given that they always have a comment.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10797

To: simgunz, #okular, aacid
Cc: aacid, ngraham, michaelweghorn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180406/e36ae2bc/attachment-0001.html>