D7996: Properly create KPixmapSequence

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D7996#149273, @aacid wrote:
  
  > Whoever decided to change from iconName to fullpath deserves some punishment for having a class constructor that has exactly signature but behaves totally different.
  >
  > every single instance is broken
  >  https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082
  >  https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147
  >  https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162
  >  https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140
  >
  > meh, i'll forget this to make my life better.
  
  
  I had a look, kdelibs has
  
    KPixmapSequence::KPixmapSequence(const QString &xdgIconName, int size)
            : d(new Private)
    {
        d->loadSequence(QPixmap(KIconLoader::global()->iconPath(xdgIconName, -size)), QSize(size, size));
    }
  
  while kwidgetaddons has
  
    KPixmapSequence::KPixmapSequence(const QString &fullPath, int size)
        : d(new Private)
    {
        d->loadSequence(QPixmap(fullPath), QSize(size, size));
    } 
  
  The weird thing is that I can't find the change with git blame. Shouldn't we just restore the old implementation?

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D7996

To: elvisangelaccio, #okular, aacid
Cc: aacid, #okular
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170926/f311d98a/attachment.html>