<table><tr><td style="">elvisangelaccio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7996" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7996#149273" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D7996#149273</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@aacid</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Whoever decided to change from iconName to fullpath deserves some punishment for having a class constructor that has exactly signature but behaves totally different.</p>

<p>every single instance is broken<br />
 <a href="https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082</a><br />
 <a href="https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147</a><br />
 <a href="https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162</a><br />
 <a href="https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140</a></p>

<p>meh, i'll forget this to make my life better.</p></div>
</blockquote>

<p>I had a look, kdelibs has</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">KPixmapSequence::KPixmapSequence(const QString &xdgIconName, int size)
        : d(new Private)
{
    d->loadSequence(QPixmap(KIconLoader::global()->iconPath(xdgIconName, -size)), QSize(size, size));
}</pre></div>

<p>while kwidgetaddons has</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">KPixmapSequence::KPixmapSequence(const QString &fullPath, int size)
    : d(new Private)
{
    d->loadSequence(QPixmap(fullPath), QSize(size, size));
}</pre></div>

<p>The weird thing is that I can't find the change with git blame. Shouldn't we just restore the old implementation?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>BRANCH</strong><div><div>Applications/17.08</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7996" rel="noreferrer">https://phabricator.kde.org/D7996</a></div></div><br /><div><strong>To: </strong>elvisangelaccio, Okular, aacid<br /><strong>Cc: </strong>aacid, Okular<br /></div>