D7714: Show dialog to ask when closing when more than tab open

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D7714#146282, @rkflx wrote:
  
  > In https://phabricator.kde.org/D7714#145952, @aacid wrote:
  >
  > > Ok, so i will abandon this and we won't ever get a fix.
  > >
  > > Because that's what's going to happen, but sure, let's do perfection instead of good enough.
  >
  >
  > I'll interpret that as a "no" to my question whether you would agree to open a a shared task. That's fine with me, we can work on Okular first and do a second round afterwards (harder, though). No need to abandon anything. (But I am also disappointed that we just assume there will be bikeshedding with the Dolphin and Konsole developers, without even trying to reach out to them.)
  
  
  I don't disagree on you wanting to make the world better, i disagree on you wanting to block an improvement because you want to fix everything at once instead of doing minor incremental fixes.
  
  > Just for the record: Please don't feel blocked by my comments (I'm not even set as a reviewer, neither did I set the status to "Changes Requested"). Maybe I just misunderstood why you posted this as a review request in the first place.
  > 
  > In https://phabricator.kde.org/D7714#146279, @ngraham wrote:
  > 
  >> I would like to re-work the patch to match Dolphin and Konsole
  > 
  > 
  > That was kind of my original suggestion: just copy what Dolphin already has. As you can read above, Albert isn't too fond of that.
  > 
  > Albert: Assuming we'll work on Okular only first, please indicate what style of dialog we should go ahead with:
  > 
  > [ ] as implemented in the original patch
  > [ ] as suggested in https://phabricator.kde.org/D7714#145582 as per your request for better wording
  > [ ] as shown in the screenshot of Dolphin
  > [ ] none/other
  
  I guess option two, though i'm not sure i totally agree with all your points there either.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7714

To: aacid, #okular, #kde_applications
Cc: alexeymin, ngraham, colomar, rkflx, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170916/6c6a304f/attachment.html>