<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7714" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7714#146282" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7714#146282</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7714#145952" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7714#145952</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Ok, so i will abandon this and we won't ever get a fix.</p>
<p>Because that's what's going to happen, but sure, let's do perfection instead of good enough.</p></div>
</blockquote>
<p>I'll interpret that as a "no" to my question whether you would agree to open a a shared task. That's fine with me, we can work on Okular first and do a second round afterwards (harder, though). No need to abandon anything. (But I am also disappointed that we just assume there will be bikeshedding with the Dolphin and Konsole developers, without even trying to reach out to them.)</p></div>
</blockquote>
<p>I don't disagree on you wanting to make the world better, i disagree on you wanting to block an improvement because you want to fix everything at once instead of doing minor incremental fixes.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Just for the record: Please don't feel blocked by my comments (I'm not even set as a reviewer, neither did I set the status to "Changes Requested"). Maybe I just misunderstood why you posted this as a review request in the first place.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7714#146279" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7714#146279</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I would like to re-work the patch to match Dolphin and Konsole</p></div>
</blockquote>
<p>That was kind of my original suggestion: just copy what Dolphin already has. As you can read above, Albert isn't too fond of that.</p>
<p>Albert: Assuming we'll work on Okular only first, please indicate what style of dialog we should go ahead with:</p>
<ul class="remarkup-list remarkup-list-with-checkmarks">
<li class="remarkup-list-item remarkup-unchecked-item"><input type="checkbox" disabled="disabled" /> as implemented in the original patch</li>
<li class="remarkup-list-item remarkup-unchecked-item"><input type="checkbox" disabled="disabled" /> as suggested in <a href="https://phabricator.kde.org/D7714#145582" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7714#145582</a> as per your request for better wording</li>
<li class="remarkup-list-item remarkup-unchecked-item"><input type="checkbox" disabled="disabled" /> as shown in the screenshot of Dolphin</li>
<li class="remarkup-list-item remarkup-unchecked-item"><input type="checkbox" disabled="disabled" /> none/other</li>
</ul></blockquote>
<p>I guess option two, though i'm not sure i totally agree with all your points there either.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7714" rel="noreferrer">https://phabricator.kde.org/D7714</a></div></div><br /><div><strong>To: </strong>aacid, Okular, KDE Applications<br /><strong>Cc: </strong>alexeymin, ngraham, colomar, rkflx, Okular, aacid<br /></div>