[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

Albert Astals Cid bugzilla_noreply at kde.org
Thu Sep 7 19:49:37 UTC 2017


https://bugs.kde.org/show_bug.cgi?id=384185

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/oku |https://commits.kde.org/oku
                   |lar/e3747ca3fd9b9926ff8c528 |lar/bedc3dbeadd450a86077030
                   |79da7fca1a620fef5           |8ffc2ca5538cf42b9

--- Comment #10 from Albert Astals Cid <aacid at kde.org> ---
Git commit bedc3dbeadd450a860770308ffc2ca5538cf42b9 by Albert Astals Cid, on
behalf of Julian Wolff.
Committed on 07/09/2017 at 19:49.
Pushed by aacid into branch 'Applications/17.08'.

Fix automatic reload of files saved with QSaveFile

Summary:
Files saved with QSaveFile don't get dirty. They are deleted and replaced.
Thus, inotify and KDirWatch don't emit a "dirty" signal (which is the correct
behaviour).
Listening for the "created" signal of KDirWatch allows us to get notified on
replaced files.

Test Plan:
Opened a markdown document in Okular.
Edited and saved the document with Kate.
The file is reloaded in Okular as expected.

Reviewers: aacid

Reviewed By: aacid

Subscribers: sander, rkflx, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7671

M  +1    -0    part.cpp

https://commits.kde.org/okular/bedc3dbeadd450a860770308ffc2ca5538cf42b9

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list