[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

Julian Wolff bugzilla_noreply at kde.org
Thu Sep 7 11:18:38 UTC 2017


https://bugs.kde.org/show_bug.cgi?id=384185

Julian Wolff <wolff at julianwolff.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/oku
                   |                            |lar/e3747ca3fd9b9926ff8c528
                   |                            |79da7fca1a620fef5
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #9 from Julian Wolff <wolff at julianwolff.de> ---
Git commit e3747ca3fd9b9926ff8c52879da7fca1a620fef5 by Julian Wolff.
Committed on 07/09/2017 at 11:18.
Pushed by jwolff into branch 'master'.

Fix automatic reload of files saved with QSaveFile

Summary:
Files saved with QSaveFile don't get dirty. They are deleted and replaced.
Thus, inotify and KDirWatch don't emit a "dirty" signal (which is the correct
behaviour).
Listening for the "created" signal of KDirWatch allows us to get notified on
replaced files.

Test Plan:
Opened a markdown document in Okular.
Edited and saved the document with Kate.
The file is reloaded in Okular as expected.

Reviewers: aacid

Reviewed By: aacid

Subscribers: sander, rkflx, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7671

M  +1    -0    part.cpp

https://commits.kde.org/okular/e3747ca3fd9b9926ff8c52879da7fca1a620fef5

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list