D7671: Fix automatic reload of files saved with QSaveFile

Albert Astals Cid noreply at phabricator.kde.org
Tue Sep 5 19:18:05 UTC 2017


aacid added a comment.


  In https://phabricator.kde.org/D7671#143202, @progwolff wrote:
  
  > ~~Okay, I modified KDirWatch so we actually get a dirty signal for the directory.~~
  >
  > Now a new problem arised. 
  >  QSaveFile does not delete and recreate the file as we thought. It just moves the swap file to the old file's location.
  >  On move, KDirWatch still sends a "created" signal for the file and a dirty signal for the directory, but the file exists all the time. This is why Okular fails to notice that the file changed as long as we don't listen for the "created" signal.
  >
  >   kf5.kcoreaddons.kdirwatch: "KDirWatch-1" emitting deleted "/home/wolff/repos/performer/README.md"
  >   org.kde.okular.ui: deleted signal
  >   org.kde.okular.ui: slotFileDirty:  "/home/wolff/repos/performer"
  >   org.kde.okular.ui: slotFileDirty:  "/home/wolff/repos/performer/README.md.Sm7640"
  >   org.kde.okular.ui: slotFileDirty:  "/home/wolff/repos/performer"
  >   kf5.kcoreaddons.kdirwatch: "KDirWatch-1" emitting created "/home/wolff/repos/performer/README.md"
  >   org.kde.okular.ui: created signal
  >
  
  
  Have you read my email? There clearly says what happens and what the documentation says it should happen (at least to my understanding of reading it).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7671

To: progwolff, aacid
Cc: sander, rkflx, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170905/c438cee3/attachment.html>


More information about the Okular-devel mailing list