D8244: Add a "share" menu to Okular

[Albert Astals Cid]

aacid added a comment.


  Can you investigate if there's a way to disable the Save As plugin?
  
  It makes zero sense for Okular

INLINE COMMENTS

> part.cpp:3145
> +    if (error) {
> +        KMessageBox::error(widget(), i18n("There was a problem sharing the image: %1", message), i18n("Share"));
> +    } else {

image -> document

> part.cpp:3148
> +        const QString url = output["url"].toString();
> +        if (url.isEmpty())
> +            KMessageBox::information(widget(), i18n("Document shared successfully"), i18n("Share"));

I'm wondering, if it just worked and there's nothing to really report maybe we can just use a

  d->messageWindow->display(  .... );

that is far less intrusive?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8244

To: ervin, aacid
Cc: #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171011/3d7f2a96/attachment-0001.html>