<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8244" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Can you investigate if there's a way to disable the Save As plugin?</p>
<p>It makes zero sense for Okular</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8244#inline-34651" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.cpp:3145</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">error</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">error</span><span class="p">(</span><span class="n">widget</span><span class="p">(),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"There was a problem sharing the image: %1"</span><span class="p">,</span> <span class="n">message</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Share"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">image -> document</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8244#inline-34653" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.cpp:3148</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">url</span> <span style="color: #aa2211">=</span> <span class="n">output</span><span class="p">[</span><span style="color: #766510">"url"</span><span class="p">].</span><span class="n">toString</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">url</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">information</span><span class="p">(</span><span class="n">widget</span><span class="p">(),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Document shared successfully"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Share"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm wondering, if it just worked and there's nothing to really report maybe we can just use a</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">d->messageWindow->display( .... );</pre></div>
<p style="padding: 0; margin: 8px;">that is far less intrusive?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8244" rel="noreferrer">https://phabricator.kde.org/D8244</a></div></div><br /><div><strong>To: </strong>ervin, aacid<br /><strong>Cc: </strong>Okular, aacid<br /></div>