D8980: Fix rubber band selection drawing contents misaligned with scaling

Anthony Fieroni noreply at phabricator.kde.org
Fri Nov 24 03:20:38 UTC 2017


anthonyfieroni added a reviewer: aacid.
anthonyfieroni added inline comments.

INLINE COMMENTS

> pageview.cpp:1708
>                              p.drawPixmap( 0, 0, doubleBuffer,
> -                                        blendRect.left() - contentsRect.left(), blendRect.top() - contentsRect.top(),
> +                                        blendRect.left() - contentsRect.left() * devicePixelRatioF(), blendRect.top() - contentsRect.top() * devicePixelRatioF(),
>                                          blendRect.width() * devicePixelRatioF(), blendRect.height() * devicePixelRatioF() );

Are you sure there haven't parentheses over subtractions

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8980

To: davidedmundson, aacid
Cc: anthonyfieroni, #okular, gassaf, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171124/7ba29ee6/attachment.html>


More information about the Okular-devel mailing list