D8980: Fix rubber band selection drawing contents misaligned with scaling

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.

REVISION SUMMARY
  in drawPixmap(source, sourceRect) the source rect is in native pixels.
  
  In this code the size was scaled by the DPR, but the location was not.
  blendRect is the contents of a selection rectangle, offset from the
  bounding darker blue rectangle. Hence we haven't really noticed.
  
  This completely fixes the rectangle when the scale == 2.0/3.0
  
  Some smaller artifacts remain on fractional scale factors, which is a
  separate code bug with the same symptoms.
  
  CCBUG: 386111

REPOSITORY
  R223 Okular

BRANCH
  scaling_fixes

REVISION DETAIL
  https://phabricator.kde.org/D8980

AFFECTED FILES
  ui/pageview.cpp

To: davidedmundson
Cc: #okular, gassaf, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171123/f73fa9de/attachment.html>