D8642: Rework saving of annotations and form data

[Burkhard Lück]

lueck added a comment.


  In https://phabricator.kde.org/D8642#167017, @aacid wrote:
  
  > In https://phabricator.kde.org/D8642#164520, @lueck wrote:
  >
  > > In https://phabricator.kde.org/D8642#164036, @aacid wrote:
  > >
  > > > Note KDE Applications 17.12 is Nov 16, it would be great if we could get this in, so please try to review ASAP :)
  > >
  > >
  > > Tried all steps in the TEST PLAN:
  > >
  > > 1. Open pdf file, add anotation, close app...  -> Works as expected But the second button in the dialog "Close Document" is labeled "Discard" or "No", depending how I close: Using window Close button first the second button is labeled "No" Using File->Close (Ctrl+W) the second button is labeled "Discard" Once I have used File->Close and selected the button "Cancel" in this dialog the dialog opened with the window Close button has the second button labeled "Discard" now instead of "No"
  >
  >
  > I can't reproduce that :( 
  >  Can anyone reproduce it?
  
  
  Wiped my frameworks environment completely, rebuild and this issue is now gone

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8642

To: aacid, mlaurent
Cc: rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171113/fd95807d/attachment.html>