D8642: Rework saving of annotations and form data

[Albert Astals Cid]

aacid marked 3 inline comments as done.
aacid added a comment.


  In https://phabricator.kde.org/D8642#164520, @lueck wrote:
  
  > In https://phabricator.kde.org/D8642#164036, @aacid wrote:
  >
  > > Note KDE Applications 17.12 is Nov 16, it would be great if we could get this in, so please try to review ASAP :)
  >
  >
  > Tried all steps in the TEST PLAN:
  >
  > 1. Open pdf file, add anotation, close app...  -> Works as expected But the second button in the dialog "Close Document" is labeled "Discard" or "No", depending how I close: Using window Close button first the second button is labeled "No" Using File->Close (Ctrl+W) the second button is labeled "Discard" Once I have used File->Close and selected the button "Cancel" in this dialog the dialog opened with the window Close button has the second button labeled "Discard" now instead of "No"
  
  
  I can't reproduce that :( 
  Can anyone reproduce it?
  
  > 
  > 
  > 2. Open png file, add anotation, close app... -> Works as expected Same issue with the label of the second button (Discard/No) in the dialog Close Document as in 1)
  
  
  
  > The dialog Warning with the option to save as document archive has a field with 
  >  one entry "User annotations", what does it mean?
  >  What does the second option "Continue" in this dialog do, I see no difference to "Cancel"?
  
  It says that you can "Continue" saving, but if you continue the "User annotations" will be lost. I guess the fact that you didn't understand it means it needs a rewording, anything you would suggest to make it more easy to understand?
  
  > 
  > 
  > 3. With old version of okular, add annotation to pdf file... -> Works as expected
  > 4. Open pdf file with forms... ->Works as expected
  > 5. Open png file add an annotation and save it as okular archive... ->Works as expected

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8642

To: aacid, mlaurent
Cc: rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171113/8d5c7f31/attachment.html>