<table><tr><td style="">aacid marked 3 inline comments as done.<br />aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8642" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8642#164520" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8642#164520</a>, <a href="https://phabricator.kde.org/p/lueck/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@lueck</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8642#164036" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8642#164036</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Note KDE Applications 17.12 is Nov 16, it would be great if we could get this in, so please try to review ASAP :)</p></div>
</blockquote>
<p>Tried all steps in the TEST PLAN:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Open pdf file, add anotation, close app... -> Works as expected But the second button in the dialog "Close Document" is labeled "Discard" or "No", depending how I close: Using window Close button first the second button is labeled "No" Using File->Close (Ctrl+W) the second button is labeled "Discard" Once I have used File->Close and selected the button "Cancel" in this dialog the dialog opened with the window Close button has the second button labeled "Discard" now instead of "No"</li>
</ol></div>
</blockquote>
<p>I can't reproduce that :( <br />
Can anyone reproduce it?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;">
<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">Open png file, add anotation, close app... -> Works as expected Same issue with the label of the second button (Discard/No) in the dialog Close Document as in 1)</li>
</ol></blockquote>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The dialog Warning with the option to save as document archive has a field with <br />
one entry "User annotations", what does it mean?<br />
What does the second option "Continue" in this dialog do, I see no difference to "Cancel"?</p></blockquote>
<p>It says that you can "Continue" saving, but if you continue the "User annotations" will be lost. I guess the fact that you didn't understand it means it needs a rewording, anything you would suggest to make it more easy to understand?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;">
<ol class="remarkup-list" start="3">
<li class="remarkup-list-item">With old version of okular, add annotation to pdf file... -> Works as expected</li>
<li class="remarkup-list-item">Open pdf file with forms... ->Works as expected</li>
<li class="remarkup-list-item">Open png file add an annotation and save it as okular archive... ->Works as expected</li>
</ol></blockquote>
</div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8642" rel="noreferrer">https://phabricator.kde.org/D8642</a></div></div><br /><div><strong>To: </strong>aacid, mlaurent<br /><strong>Cc: </strong>rkflx, lueck, mlaurent, michaelweghorn, ngraham, Okular, aacid<br /></div>