D8690: Fix use of OpenUrlArguments

Albert Astals Cid noreply at phabricator.kde.org
Sat Nov 11 23:04:21 UTC 2017


aacid added inline comments.

INLINE COMMENTS

> progwolff wrote in part.cpp:1400
> I changed the order here.
> Now mime types defined by OpenUrlArguments are prefered. This allows opening files with wrong endings by forcing the right mime type.

I don't think this is a good idea, do you have an actual case in which this helps or is it just a guess?

Also have you tried that this doesn't break the fixes that https://phabricator.kde.org/R223:fba90677fcc9ccf0e6f5efe75e7446703d669d36 speaks of?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8690

To: progwolff, aacid
Cc: #okular, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171111/da366feb/attachment.html>


More information about the Okular-devel mailing list