<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8690" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8690#inline-38272" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">progwolff</span> wrote in <span style="color: #4b4d51; font-weight: bold;">part.cpp:1400</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I changed the order here.<br />
Now mime types defined by OpenUrlArguments are prefered. This allows opening files with wrong endings by forcing the right mime type.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think this is a good idea, do you have an actual case in which this helps or is it just a guess?</p>
<p style="padding: 0; margin: 8px;">Also have you tried that this doesn't break the fixes that <a href="https://phabricator.kde.org/R223:fba90677fcc9ccf0e6f5efe75e7446703d669d36" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">fba90677fcc9ccf0e6f5efe75e7446703d669d36</a> speaks of?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8690" rel="noreferrer">https://phabricator.kde.org/D8690</a></div></div><br /><div><strong>To: </strong>progwolff, aacid<br /><strong>Cc: </strong>Okular, ngraham, aacid<br /></div>