Review Request 130057: Bug 288042 - Option to reset forms

[Albert Astals Cid]

> On set. 26, 2017, 9:57 p.m., Albert Astals Cid wrote:
> > Do you think you could do an autotest using formSamples.pdf ?
> 
> Gilbert Assaf wrote:
>     I don't know how to put text into a PageViewItem from an autotest class. I can't access the necessary members, because of the way PageViewPrivate is declared. Even with friending classes I could not get it to work. 
>     I think the only way to create an autotest is to reimplement this functionality using Okular::FormField.

There's tests that already do that, get inspired by them.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/#review103741
-----------------------------------------------------------


On set. 23, 2017, 7:08 p.m., Gilbert Assaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130057/
> -----------------------------------------------------------
> 
> (Updated set. 23, 2017, 7:08 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 288042
>     http://bugs.kde.org/show_bug.cgi?id=288042
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks CheckBoxEdit and ListEdit form elements. 
> 
> I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state I should reset/clear them. Especially for ComboBox, I am not sure if clearing them could be harmful.
> 
> 
> Diffs
> -----
> 
>   part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
>   ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
>   ui/formwidgets.cpp a1215ce7d88b428dccdc5cac54ad6c934a81d494 
>   ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
>   ui/pageview.cpp 9766422b927d23330ce9fced5af8d406cee6ccd2 
>   ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
>   ui/pageviewutils.cpp a46384afb3f976842d6693b60fb01fd474481d0d 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130057/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171105/ff308a1e/attachment.html>