<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130057/">https://git.reviewboard.kde.org/r/130057/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On setembre 26th, 2017, 9:57 p.m. UTC, <strong>Albert Astals Cid</strong> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do you think you could do an autotest using formSamples.pdf ?</p></pre>
</blockquote>
<p>On novembre 4th, 2017, 12:57 p.m. UTC, <strong>Gilbert Assaf</strong> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't know how to put text into a PageViewItem from an autotest class. I can't access the necessary members, because of the way PageViewPrivate is declared. Even with friending classes I could not get it to work.
I think the only way to create an autotest is to reimplement this functionality using Okular::FormField.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There's tests that already do that, get inspired by them.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On setembre 23rd, 2017, 7:08 p.m. UTC, Gilbert Assaf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Gilbert Assaf.</div>
<p style="color: grey;"><em>Updated set. 23, 2017, 7:08 p.m.</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a href="http://bugs.kde.org/show_bug.cgi?id=288042">288042</a>
</div>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks CheckBoxEdit and ListEdit form elements. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state I should reset/clear them. Especially for ComboBox, I am not sure if clearing them could be harmful.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part.rc <span style="color: grey">(34a1160ef5d7b8f65e14a457f1b39bbb06fe3074)</span></li>
<li>ui/formwidgets.h <span style="color: grey">(b1bc11a4f7048935614ad384cc49dd1cd2b1336c)</span></li>
<li>ui/formwidgets.cpp <span style="color: grey">(a1215ce7d88b428dccdc5cac54ad6c934a81d494)</span></li>
<li>ui/pageview.h <span style="color: grey">(43b03b0f677781cb92402e8291335424da210b65)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(9766422b927d23330ce9fced5af8d406cee6ccd2)</span></li>
<li>ui/pageviewutils.h <span style="color: grey">(ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80)</span></li>
<li>ui/pageviewutils.cpp <span style="color: grey">(a46384afb3f976842d6693b60fb01fd474481d0d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130057/diff/4/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>