Review Request 130043: Remove method FilePrinter::psPaperSize

[Oliver Sander]

> On March 22, 2017, 10:55 p.m., Albert Astals Cid wrote:
> > This is not binary compatible (i.e. it removes a symbol from a publicly installed header).
> > 
> > It should have been removed when we moved to KF5, but since it wasn't if there's no other reason that "we don't use it" I would prefer to keep it until we have some other forced binary compatibility break.

Okay.  So here is a new page that at least gets rid of that long list of hard-coded paper sizes.

I know it is silly to clean up a method that is not used anyway; I am mainly improving my Qt skills. :-)  Feel free to discard the patch.


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130043/#review102934
-----------------------------------------------------------


On March 23, 2017, 5:33 a.m., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130043/
> -----------------------------------------------------------
> 
> (Updated March 23, 2017, 5:33 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> I was about to simplify the method FilePrinter::psPaperSize in the file fileprinter.cpp.  As it turned out, this method is never called anywhere anyway.  So this patch removes it.
> 
> 
> Diffs
> -----
> 
>   core/fileprinter.cpp a27529e7 
> 
> Diff: https://git.reviewboard.kde.org/r/130043/diff/
> 
> 
> Testing
> -------
> 
> Grepping for the method name doesn't return anything.
> 
> Code still builds without the method.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170323/006597da/attachment.html>