Review Request 130043: Remove method FilePrinter::psPaperSize
Oliver Sander
oliver.sander at tu-dresden.de
Thu Mar 23 05:33:33 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130043/
-----------------------------------------------------------
(Updated March 23, 2017, 5:33 a.m.)
Review request for Okular.
Changes
-------
Keep the method, but simplify it by using QPageSize.
Repository: okular
Description
-------
I was about to simplify the method FilePrinter::psPaperSize in the file fileprinter.cpp. As it turned out, this method is never called anywhere anyway. So this patch removes it.
Diffs (updated)
-----
core/fileprinter.cpp a27529e7
Diff: https://git.reviewboard.kde.org/r/130043/diff/
Testing
-------
Grepping for the method name doesn't return anything.
Code still builds without the method.
Thanks,
Oliver Sander
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170323/f20869b1/attachment.html>
More information about the Okular-devel
mailing list