Review Request 130022: Remove kactivities on windows, Part II

Oliver Sander oliver.sander at tu-dresden.de
Sat Mar 18 00:58:47 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130022/
-----------------------------------------------------------

(Updated March 17, 2017, 6:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 3859fba07d67db264974b16838f76d2e5f20eb57 by Albert Vaca on behalf of Oliver Sander to branch master.


Repository: okular


Description
-------

KActivities is not used on Windows, so a hard dependency on it
only brings unneeded code.
This patch removes it completely under Windows.

This is continuation of https://git.reviewboard.kde.org/r/126378/ , where I am not allowed to post patches.


Diffs
-----

  CMakeLists.txt 2f75a9f1 
  shell/CMakeLists.txt 59a8d76d 
  shell/shell.h 20e7c053 
  shell/shell.cpp 448b9ff7 

Diff: https://git.reviewboard.kde.org/r/130022/diff/


Testing
-------

None, really, because I don't have a windows machine.


Thanks,

Oliver Sander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170318/331c4459/attachment.html>


More information about the Okular-devel mailing list