Review Request 130022: Remove kactivities on windows, Part II
Albert Vaca Cintora
albertvaka at gmail.com
Fri Mar 17 11:16:37 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130022/#review102892
-----------------------------------------------------------
I'll test in on a Windows machine this weekend :)
- Albert Vaca Cintora
On mar. 16, 2017, 1:23 p.m., Oliver Sander wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130022/
> -----------------------------------------------------------
>
> (Updated mar. 16, 2017, 1:23 p.m.)
>
>
> Review request for Okular.
>
>
> Repository: okular
>
>
> Description
> -------
>
> KActivities is not used on Windows, so a hard dependency on it
> only brings unneeded code.
> This patch removes it completely under Windows.
>
> This is continuation of https://git.reviewboard.kde.org/r/126378/ , where I am not allowed to post patches.
>
>
> Diffs
> -----
>
> CMakeLists.txt 2f75a9f1
> shell/CMakeLists.txt 59a8d76d
> shell/shell.h 20e7c053
> shell/shell.cpp 448b9ff7
>
> Diff: https://git.reviewboard.kde.org/r/130022/diff/
>
>
> Testing
> -------
>
> None, really, because I don't have a windows machine.
>
>
> Thanks,
>
> Oliver Sander
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170317/ccea9963/attachment.html>
More information about the Okular-devel
mailing list