Review Request 129785: Stop debug spam in release builds

Sat Mar 11 22:30:05 UTC 2017

> On Gen. 7, 2017, 2:24 p.m., Luigi Toscano wrote:
> > Does it mean that you can't override the setting using kdebugsettings? If it's the case, it's probably a no-go.
> 
> Miklós Máté wrote:
>     Oh, sorry I didn't realize how important this is:
>     "/usr/local/lib/x86_64-linux-gnu/plugins/okular/generators/okularGenerator_poppler.so"
>     org.kde.okular.core: Output DPI: QSizeF(94.1467, 94.0741)
>     org.kde.okular.core: request observer=0x56187c9b8210 853x1205 at 0
>     org.kde.okular.core: request observer=0x56187c9b8210 853x1205 at 1
>     org.kde.okular.core: sending request observer=0x56187c9b8210 853x1205 at 0 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 853x1205 at 0
>     org.kde.okular.core: request observer=0x56187c9b8210 853x1205 at 1
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 0
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 1
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 0 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 0
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 1
>     org.kde.okular.core: requestDone with generator not in READY state.
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 1 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 0
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 1
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 2
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 3
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 4
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 5
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 0 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 1 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 2 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 3 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 4 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 5 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 2
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 2 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 3
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 3 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 4
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 4 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 5
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 5 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 6
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 6 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 7
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 7 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 6
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 6 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 8
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 8 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 7
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 7 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 8
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 8 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 9
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 9 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 9
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 9 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 10
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 10 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 10
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 10 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 11
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 11 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 11
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 11 async == true isTile == false
>     org.kde.okular.core: About to save document info to "/home/miki/.local/share/okular/docdata/269712.flowratios.pdf.xml"
>     No frame loaded
>     No frame loaded
>     No frame loaded
>     
>     (BTW I couldn't track down where the last three lines are printed on exit)
>     
>     The kdebugdialog5 settings have no effect on these printouts (I disabled everything for okular, and checked "Disable all debug output" to be sure), probably because they are qDebug and not kDebug. I have two questions about this tool:
>     - How did you find it? It doesn't have a menu entry.
>     - Is there a difference between kdebugdialog and kdebugdialog5?
> 
> Miklós Máté wrote:
>     One more thing: the debug spam from Okular is nothing compared to the Help Center.
> 
> Albert Astals Cid wrote:
>     Why are you using kdebugdialog5 when Luigi said kdebugsettings ?
> 
> Miklós Máté wrote:
>     I thought they were the same thing. Now I see that there is indeed a separate package called kdebugsettings, which is not part of the default install. Anyways. It doesn't list Okular in the "KDE application" tab, and "Turn Off Debug" doesn't stop Okular's debug spam (neither does it silence khelpcenter). Do I need to add a custom rule? How? I tried "okular.debug=false", but it didn't do anything.
> 
> Luigi Toscano wrote:
>     KDebugSettings is part of KDE Applications. Is it installed in the same environment where Okular is installed? If I compile both in my kdesrc-build environment,  kdebugsettings has Okular categories (same for KHelpCenter). If you still some messages it's likely because it used qDebug (or still kDebug) and it was not ported to the categorized version (qCDebug).
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     «No frame loaded» is from kwidgetsaddons. It should be gone now: https://commits.kde.org/kwidgetsaddons/91f77834e5454dbc9a7476aa783fadc89d87ccc9
> 
> Miklós Máté wrote:
>     What do you mean by "same environment"? I have installed KDE with apt-get install, but Debian Unstable only has the Qt4 version of Okular, and I installed the Qt5 one from git into /usr/local.
> 
> Luigi Toscano wrote:
>     And did you set the environment variables so that the self-compiled Okular is found first, I guess. But then did you run kdebugsettings with the same environment variables set? What if you compile kdebugsettings also in that directory?
> 
> Albert Astals Cid wrote:
>     Miklós?
> 
> Miklós Máté wrote:
>     I gave up. With so many different ways of logging and so many obscure tools for controlling the output it's a byzantine mess.
>     
>     I saw the other review request (129832), which got shipped. I don't think it's the right thing to mark debug messages as 'warning' to hide them by default, but it's not my project, so I guess my opinion has low value on this. Okular is not alone with this problem though, I noticed that every kde5 application prints lots of debug messages, and the Gnome folks have a similar bad habit. Maybe I'm the only one that starts graphical applications from terminal?

I beg to differ. The Qt logging is well documented. Most libraries use the categorized logging, and porting is not difficult (at least two frameworks have been ported in the last two months), and this is controller by kdebugsettings, which simply writes qtlogging.ini, where you can override the default value (the one that you have seen in the other commit, which is then not problematic and the proper solution to the problem).

Some applications have not been ported to categorized logging (you can recognize it by the "(default)" as the category name, instead of "(org.kde.okular.core)" or similar, but then see the previous point.

Frameworks does not add any special magic on top of the Qt system (for whoever will read it this, there is no such thing as "kde5"). I have no idea what GTK and/or applications by Gnome do.

Which debug information do you see now, if you disable all categorized logging? It's probably easier to port the non-categorizzed logging to the new system.

- Luigi

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129785/#review101848
-----------------------------------------------------------

On Gen. 7, 2017, 1:51 p.m., Miklós Máté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129785/
> -----------------------------------------------------------
> 
> (Updated Gen. 7, 2017, 1:51 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Okular core prints lots of debug messages, stop that in release builds.
> 
> 
> Diffs
> -----
> 
>   OkularConfigureChecks.cmake 70fe8768 
>   ui/formwidgets.cpp 7e68b5c7 
> 
> Diff: https://git.reviewboard.kde.org/r/129785/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170311/f9824b2a/attachment.html>