<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129785/">https://git.reviewboard.kde.org/r/129785/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On gennaio 7th, 2017, 2:24 p.m. CET, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Does it mean that you can't override the setting using kdebugsettings? If it's the case, it's probably a no-go.</p></pre>
</blockquote>
<p>On gennaio 12th, 2017, 12:07 a.m. CET, <b>Miklós Máté</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, sorry I didn't realize how important this is:
"/usr/local/lib/x86_64-linux-gnu/plugins/okular/generators/okularGenerator_poppler.so"
org.kde.okular.core: Output DPI: QSizeF(94.1467, 94.0741)
org.kde.okular.core: request observer=0x56187c9b8210 853x1205@0
org.kde.okular.core: request observer=0x56187c9b8210 853x1205@1
org.kde.okular.core: sending request observer=0x56187c9b8210 853x1205@0 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 853x1205@0
org.kde.okular.core: request observer=0x56187c9b8210 853x1205@1
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@0
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@1
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@0 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@0
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@1
org.kde.okular.core: requestDone with generator not in READY state.
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@1 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@0
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@1
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@2
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@3
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@4
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@5
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@0 async == true isTile == false
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@1 async == true isTile == false
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@2 async == true isTile == false
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@3 async == true isTile == false
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@4 async == true isTile == false
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@5 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@2
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@2 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@3
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@3 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@4
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@4 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@5
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@5 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@6
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@6 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@7
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@7 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@6
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@6 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@8
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@8 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@7
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@7 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@8
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@8 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@9
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@9 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@9
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@9 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@10
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@10 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@10
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@10 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9b8210 833x1177@11
org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@11 async == true isTile == false
org.kde.okular.core: request observer=0x56187c9a19e0 108x153@11
org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@11 async == true isTile == false
org.kde.okular.core: About to save document info to "/home/miki/.local/share/okular/docdata/269712.flowratios.pdf.xml"
No frame loaded
No frame loaded
No frame loaded
(BTW I couldn't track down where the last three lines are printed on exit)
The kdebugdialog5 settings have no effect on these printouts (I disabled everything for okular, and checked "Disable all debug output" to be sure), probably because they are qDebug and not kDebug. I have two questions about this tool:
- How did you find it? It doesn't have a menu entry.
- Is there a difference between kdebugdialog and kdebugdialog5?</pre>
</blockquote>
<p>On gennaio 12th, 2017, 12:08 a.m. CET, <b>Miklós Máté</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One more thing: the debug spam from Okular is nothing compared to the Help Center.</pre>
</blockquote>
<p>On gennaio 12th, 2017, 12:14 a.m. CET, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why are you using kdebugdialog5 when Luigi said kdebugsettings ?</p></pre>
</blockquote>
<p>On gennaio 12th, 2017, 1 a.m. CET, <b>Miklós Máté</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought they were the same thing. Now I see that there is indeed a separate package called kdebugsettings, which is not part of the default install. Anyways. It doesn't list Okular in the "KDE application" tab, and "Turn Off Debug" doesn't stop Okular's debug spam (neither does it silence khelpcenter). Do I need to add a custom rule? How? I tried "okular.debug=false", but it didn't do anything.</pre>
</blockquote>
<p>On gennaio 12th, 2017, 1:18 a.m. CET, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDebugSettings is part of KDE Applications. Is it installed in the same environment where Okular is installed? If I compile both in my kdesrc-build environment, kdebugsettings has Okular categories (same for KHelpCenter). If you still some messages it's likely because it used qDebug (or still kDebug) and it was not ported to the categorized version (qCDebug).</p></pre>
</blockquote>
<p>On gennaio 15th, 2017, 1:21 p.m. CET, <b>Martin Tobias Holmedahl Sandsmark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">«No frame loaded» is from kwidgetsaddons. It should be gone now: https://commits.kde.org/kwidgetsaddons/91f77834e5454dbc9a7476aa783fadc89d87ccc9</p></pre>
</blockquote>
<p>On gennaio 15th, 2017, 4:50 p.m. CET, <b>Miklós Máté</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What do you mean by "same environment"? I have installed KDE with apt-get install, but Debian Unstable only has the Qt4 version of Okular, and I installed the Qt5 one from git into /usr/local.</p></pre>
</blockquote>
<p>On gennaio 15th, 2017, 5:07 p.m. CET, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And did you set the environment variables so that the self-compiled Okular is found first, I guess. But then did you run kdebugsettings with the same environment variables set? What if you compile kdebugsettings also in that directory?</p></pre>
</blockquote>
<p>On marzo 11th, 2017, 5:58 p.m. CET, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Miklós?</p></pre>
</blockquote>
<p>On marzo 11th, 2017, 11:17 p.m. CET, <b>Miklós Máté</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I gave up. With so many different ways of logging and so many obscure tools for controlling the output it's a byzantine mess.
I saw the other review request (129832), which got shipped. I don't think it's the right thing to mark debug messages as 'warning' to hide them by default, but it's not my project, so I guess my opinion has low value on this. Okular is not alone with this problem though, I noticed that every kde5 application prints lots of debug messages, and the Gnome folks have a similar bad habit. Maybe I'm the only one that starts graphical applications from terminal?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I beg to differ. The Qt logging is well documented. Most libraries use the categorized logging, and porting is not difficult (at least two frameworks have been ported in the last two months), and this is controller by kdebugsettings, which simply writes qtlogging.ini, where you can override the default value (the one that you have seen in the other commit, which is then not problematic and the proper solution to the problem).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some applications have not been ported to categorized logging (you can recognize it by the "(default)" as the category name, instead of "(org.kde.okular.core)" or similar, but then see the previous point.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Frameworks does not add any special magic on top of the Qt system (for whoever will read it this, there is no such thing as "kde5"). I have no idea what GTK and/or applications by Gnome do.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Which debug information do you see now, if you disable all categorized logging? It's probably easier to port the non-categorizzed logging to the new system.</p></pre>
<br />
<p>- Luigi</p>
<br />
<p>On gennaio 7th, 2017, 1:51 p.m. CET, Miklós Máté wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Miklós Máté.</div>
<p style="color: grey;"><i>Updated Gen. 7, 2017, 1:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Okular core prints lots of debug messages, stop that in release builds.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>OkularConfigureChecks.cmake <span style="color: grey">(70fe8768)</span></li>
<li>ui/formwidgets.cpp <span style="color: grey">(7e68b5c7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129785/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>